jyu2 added inline comments.
================ Comment at: lib/Sema/JumpDiagnostics.cpp:675 + // asm-goto. + //if (!IsAsmGoto && IndirectJumpTargets.empty()) { + if (JumpTargets.empty()) { ---------------- efriedma wrote: > Commented-out code? > > We probably don't need a diagnostic for an asm goto which doesn't have any > labels. If we do, it shouldn't be here. :-(!!!! Yes, you are right! We don't need a diagnostic for asm goto. The error will be giving during parser. I changed. Thank you so much for your review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits