andrewrk accepted this revision.
andrewrk added a comment.
I confirm this solves the issue.
================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1739
execute_process(COMMAND ${GIT_EXECUTABLE} rev-parse --git-dir
WORKING_DIRECTORY ${path}
RESULT_VARIABLE git_result
----------------
I think ${path} should still be quoted here for best practice, as well as
${GIT_EXECUTABLE} above.
================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1745
string(STRIP "${git_output}" git_output)
get_filename_component(git_dir ${git_output} ABSOLUTE BASE_DIR ${path})
# Some branchless cases (e.g. 'repo') may not yet have .git/logs/HEAD
----------------
these variables should be quoted too
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58204/new/
https://reviews.llvm.org/D58204
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
