[PATCH] D58152: [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with a testing request.



================
Comment at: clang/test/SemaObjC/attr-designated-init.m:433-438
+- (instancetype)foo
+    __attribute__((objc_designated_initializer))
+    __attribute__((objc_method_family(init)));
+- (instancetype)bar
+    __attribute__((objc_method_family(init)))
+    __attribute__((objc_designated_initializer));
----------------
For coverage purposes, can you add these tests as well?
```
- (instancetype)baz
    __attribute__((objc_designated_initializer, objc_method_family(init)))
- (instancetype)quux
    __attribute__((objc_method_family(init), objc_designated_initializer))
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58152/new/

https://reviews.llvm.org/D58152



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits