tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lib/CodeGen/CGCUDANV.cpp:412
+ for (auto &&I : EmittedKernels) {
+ llvm::Constant *KernelName = makeConstantString(I.DeviceSideName);
llvm::Constant *NullPtr = llvm::ConstantPointerNull::get(VoidPtrTy);
----------------
yaxunl wrote:
> tra wrote:
> > Can we just call `getDeviceSideName()` here ? Mangling the name early and
> > carrying it around does not seem to buy us anything.
> getDeviceSideName() need to know Decl of the function. If we want to call it
> here, we have to carry Decl of the functions around.
I see. We appear to get both the Decl and llvm::function from CodeGenFunction.
Perhaps we can make `EmittedKernels` a vector<CodeGenFunction*>.
It's just a nit. I'll leave it up to you.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58163/new/
https://reviews.llvm.org/D58163
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
