thakis added a comment.

> In D54978#1393552 <https://reviews.llvm.org/D54978#1393552>, @ddcc wrote:
> 
>> The likely reason for this versioning problem is that the current versioning 
>> implementation in FindZ3.cmake is best-effort only.
> 
> 
> Thank you @ddcc for this explanation. If that's the case I'd really prefer if 
> `LLVM_ENABLE_Z3_SOLVER` was explicit opt-in and defaulted to `OFF` regardless 
> of what `find_package` returned.

Do you understand why the default matters for you? You seem to explicitly 
disable the setting, and you still get Z3 as part of your build. Did you make a 
clean build dir before turning it to OFF? If so, I don't understand why the 
default setting is important to you and why this doesn't work for you. (I don't 
disagree with the default being off, I'm just confused why things don't work 
for you.)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54978/new/

https://reviews.llvm.org/D54978



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to