efriedma marked 2 inline comments as done.
efriedma added inline comments.

================
Comment at: lib/Sema/SemaInit.cpp:172-173
+      E = PE->getSubExpr();
+    else if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E))
+      E = UO->getSubExpr();
+    else if (GenericSelectionExpr *GSE = dyn_cast<GenericSelectionExpr>(E))
----------------
rsmith wrote:
> I guess this is just for `UO_Extension`. Is it worth asserting that?
I don't think it's likely that anyone would ever trip the assertion, but maybe 
worthwhile just to document the meaning, sure.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58069/new/

https://reviews.llvm.org/D58069



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D58069: [... Eli Friedman via Phabricator via cfe-commits
    • [PATCH] D580... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D580... Eli Friedman via Phabricator via cfe-commits
    • [PATCH] D580... Eli Friedman via Phabricator via cfe-commits
    • [PATCH] D580... Artem Dergachev via Phabricator via cfe-commits

Reply via email to