On Tue, May 8, 2018 at 3:59 AM Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> Author: ericwf > Date: Tue May 8 00:56:05 2018 > New Revision: 331745 > > URL: http://llvm.org/viewvc/llvm-project?rev=331745&view=rev > Log: > [C++2a] Implement operator<=>: Fix another bug in the code gen tests. > > Sorry for the failures. I'm quite new at writing code gen tests, and > I'm not sure the best way to make them portable. > > Modified: > cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp > > Modified: cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp?rev=331745&r1=331744&r2=331745&view=diff > > ============================================================================== > --- cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp (original) > +++ cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp Tue May 8 00:56:05 2018 > @@ -79,7 +79,8 @@ auto mem_ptr_test(MemPtrT x, MemPtrT y) > // CHECK: %cmp.ptr = icmp eq [[TY:i[0-9]+]] %lhs.memptr.ptr, > %rhs.memptr.ptr > // CHECK: %cmp.ptr.null = icmp eq [[TY]] %lhs.memptr.ptr, 0 > // CHECK: %cmp.adj = icmp eq [[TY]] %lhs.memptr.adj, %rhs.memptr.adj > - // CHECK: %[[OR:.*]] = or i1 %cmp.ptr.null, %cmp.adj > + // CHECK: %[[OR:.*]] = or i1 > + // CHECK-SAME %cmp.adj > This is missing the ':' and now doesn't check anything. > // CHECK: %memptr.eq = and i1 %cmp.ptr, %[[OR]] > // CHECK: %sel.eq = select i1 %memptr.eq, i8 [[EQ]], i8 [[NE]] > // CHECK: %__value_ = getelementptr inbounds %[[SE]], %[[SE]]* %[[DEST]] > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits