erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land.
The justification is correct based on my research into this problem, and the code changes themselves look correct. I cannot think of any reason why re-stating the alignment will matter in GCC mode, so I think this is OK. I'll accept, but I'd really like to give @rnk a chance to take a look to make sure there isn't something I'm missing. ================ Comment at: test/CodeGen/x86-vec-struct-packing.c:14 +#if defined(_WIN32) +static int a1[(sizeof(m128) == 32) - 1]; +#else ---------------- We default to C++14, do we not use static-asserts for this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57961/new/ https://reviews.llvm.org/D57961 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
