On Thu, Jan 21, 2016 at 9:27 AM, Daniel Sanders <daniel.sand...@imgtec.com> wrote:
> Hi, > > > > It was LGTM'd by bcraig. > Specifically, he said "LGTM, but that doesn't mean much." -- Marshall > > > *From:* Marshall Clow [mailto:mclow.li...@gmail.com] > *Sent:* 21 January 2016 17:25 > *To:* Hans Wennborg > *Cc:* Daniel Sanders; cfe-commits > *Subject:* Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' > directives to tests that require en_US.UTF-8. > > > > On Thu, Jan 21, 2016 at 9:05 AM, Hans Wennborg <h...@chromium.org> wrote: > > Hi Marshall, > > Is this OK for 3.8? > > > > I have no idea; this is the first I've seen of it. > > Apparently it was posted on phab, no one approved it, and it was committed. > > > > In an hour. > > > > -- Marshall > > > > > > > > > Daniel, I assume we want reviews.llvm.org/D16408 too when that lands, > right? > > Thanks, > Hans > > > On Thu, Jan 21, 2016 at 7:35 AM, Daniel Sanders via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: dsanders > > Date: Thu Jan 21 09:35:15 2016 > > New Revision: 258403 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=258403&view=rev > > Log: > > [libcxx] Add appropriate 'REQUIRE' directives to tests that require > en_US.UTF-8. > > > > Reviewers: mclow.lists, hans > > > > Subscribers: bcraig, cfe-commits > > > > Differential Revision: http://reviews.llvm.org/D16406 > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
