martong added inline comments.
================
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:232
+
+ // We do not support CTU across languages (C vs C++).
if (LangTo.CPlusPlus != LangFrom.CPlusPlus) {
----------------
a_sidorin wrote:
> The comment change looks strange.
Ok, I reverted this hunk.
================
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:255
+ LangTo.CPlusPlus2a != LangFrom.CPlusPlus2a) {
+ ++NumLangMismatch;
+ return llvm::make_error<IndexError>(index_error_code::lang_mismatch);
----------------
a_sidorin wrote:
> Should we create another counter, like NumLangDialectMismatch?
Okay, I added the new error code `lang_dialect_mismatch` too.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57906/new/
https://reviews.llvm.org/D57906
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
