sbc100 added inline comments.
================ Comment at: lib/Driver/ToolChains/WebAssembly.cpp:66 + if (Args.hasFlag(clang::driver::options::OPT_pthread, + clang::driver::options::OPT_no_pthread), + false) ---------------- aheejin wrote: > This code is not strictly related, but `hasFlag` is better than `hasArg` when > there are both positive and negative versions of an option exist. Hmm.. there are currently no other references to OPT_no_pthread in the whole codebase. Maybe better to simply remove the option? I wouldn't want to commit this as that first use of the option as it might make it hard to remove :) ================ Comment at: lib/Driver/ToolChains/WebAssembly.cpp:201 + if (HasAtomics || HasPthread) + return "posix"; return "single"; ---------------- We are currently the only platform that overrides this.. i hope it can be removed completely at some point .. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
