MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added inline comments.
================
Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:257
Ctx->getLangOpts());
};
----------------
@aaron.ballman, slight aside (and not in the code I introduced), when I run
clang-tidy on the code I'm sending for review, I get the following...
```
C:\clang\llvm\tools\clang\tools\extra\clang-tidy\bugprone\ArgumentCommentCheck.cpp:253:8:
warning: invalid case style for variable 'makeFileCharRange'
[readability-identifier-naming]
auto makeFileCharRange = [Ctx](SourceLocation Begin, SourceLocation End) {
^~~~~~~~~~~~~~~~~
MakeFileCharRange
```
according to the .clang-tidy, a variable should be CamelCase, and a function
camelBack, as its a Lambda what do we consider it should be? and does this
really require an improvement in readability-identifier-naming? (might be
something I'd be happy to look at next)
```
Checks:
'-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming'
CheckOptions:
- key: readability-identifier-naming.ClassCase
value: CamelCase
- key: readability-identifier-naming.EnumCase
value: CamelCase
- key: readability-identifier-naming.FunctionCase
value: camelBack
- key: readability-identifier-naming.MemberCase
value: CamelCase
- key: readability-identifier-naming.ParameterCase
value: CamelCase
- key: readability-identifier-naming.UnionCase
value: CamelCase
- key: readability-identifier-naming.VariableCase
value: CamelCase
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57674/new/
https://reviews.llvm.org/D57674
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
