jyknight marked an inline comment as done. jyknight added inline comments.
================ Comment at: clang/lib/CodeGen/CGCall.cpp:3837 + // having pointee types). + llvm::FunctionType *IRFuncTyFromInfo = getTypes().GetFunctionType(CallInfo); + assert(IRFuncTy == IRFuncTyFromInfo); ---------------- dblaikie wrote: > This will be warned as unused in a release build. > > Would this be hideous if it's just all one big assert? > > assert((CallInfo.isVariadic && CallInfo.getArgStruct) || IRFuncTy == > getTypes().GetFunctionType(CallInfo)); > > (I think that's accurate?) Clearer IMO to just put #ifndef NDEBUG around the block, so I'll do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57664/new/ https://reviews.llvm.org/D57664 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
