hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang-tidy/abseil/DurationUnnecessaryConversionCheck.cpp:50 + + diag(OuterCall->getBeginLoc(), "remove double conversion of absl::Duration") + << FixItHint::CreateReplacement( ---------------- also avoid `double` word in the message. ================ Comment at: docs/clang-tidy/checks/abseil-duration-unnecessary-conversion.rst:17 + + // Suggestion - Remove double conversion + absl::Duration d2 = d1; ---------------- and here. ================ Comment at: docs/clang-tidy/checks/abseil-duration-unnecessary-conversion.rst:25 + + // Suggestion - Remove double conversion + absl::Duration d2 = d1; ---------------- and here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57353/new/ https://reviews.llvm.org/D57353 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
