ilya-biryukov added inline comments.
================ Comment at: clang-tools-extra/clangd/Protocol.cpp:425 +const llvm::StringLiteral ExecuteCommandParams::CLANGD_APPLY_TWEAK = + "clangd.applyCodeAction"; + ---------------- sammccall wrote: > tweak or applyTweak Done. Thanks for spotting this, totally missed it. ================ Comment at: clang-tools-extra/clangd/SourceCode.h:59 +/// care to avoid comparing the result with expansion locations. +llvm::Expected<SourceLocation> sourceLocationInMainFile(const SourceManager &SM, + Position P); ---------------- sammccall wrote: > (can we add a unit test for this function?) Added a test in `ClangdUnitTests` for a lack of a better place. `SourceCodeTests` only test non-source-manager-related things, so adding a dependency on `SourceManager` there seemed weird. Happy to move them elsewhere, let me know what you think. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56267/new/ https://reviews.llvm.org/D56267 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
