Merged to 8.0 in r352368.
On Fri, Jan 25, 2019 at 11:05 AM Jonas Toth via cfe-commits <cfe-commits@lists.llvm.org> wrote: > > Author: jonastoth > Date: Fri Jan 25 11:05:12 2019 > New Revision: 352231 > > URL: http://llvm.org/viewvc/llvm-project?rev=352231&view=rev > Log: > [clang-tidy] fix unit tests for dropped _Float16 support in X86 > > Summary: > Because _Float16 was disabled for X86 targets the unit-tests started failing. > Extract the pieces for _Float16 and run theses tests under AArch64. > > Reviewers: aaron.ballman, erichkeane, lebedev.ri > > Reviewed By: erichkeane > > Subscribers: javed.absar, xazax.hun, kristof.beyls, cfe-commits > > Differential Revision: https://reviews.llvm.org/D57249 > > Added: > > clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-float16.cpp > Modified: > > clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-floating-point.cpp > > clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-hexadecimal-floating-point.cpp > > Added: > clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-float16.cpp > URL: > http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-float16.cpp?rev=352231&view=auto > ============================================================================== > --- > clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-float16.cpp > (added) > +++ > clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-float16.cpp > Fri Jan 25 11:05:12 2019 > @@ -0,0 +1,51 @@ > +// RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- > -target aarch64-linux-gnu -I %S > + > +#include "readability-uppercase-literal-suffix.h" > + > +void float16_normal_literals() { > + // _Float16 > + > + static constexpr auto v14 = 1.f16; > + // CHECK-MESSAGES: :[[@LINE-1]]:31: warning: floating point literal has > suffix 'f16', which is not uppercase > + // CHECK-MESSAGES-NEXT: static constexpr auto v14 = 1.f16; > + // CHECK-MESSAGES-NEXT: ^ ~ > + // CHECK-MESSAGES-NEXT: {{^ *}}F16{{$}} > + // CHECK-FIXES: static constexpr auto v14 = 1.F16; > + static_assert(is_same<decltype(v14), const _Float16>::value, ""); > + static_assert(v14 == 1.F16, ""); > + > + static constexpr auto v15 = 1.e0f16; > + // CHECK-MESSAGES: :[[@LINE-1]]:31: warning: floating point literal has > suffix 'f16', which is not uppercase > + // CHECK-MESSAGES-NEXT: static constexpr auto v15 = 1.e0f16; > + // CHECK-MESSAGES-NEXT: ^ ~ > + // CHECK-MESSAGES-NEXT: {{^ *}}F16{{$}} > + // CHECK-FIXES: static constexpr auto v15 = 1.e0F16; > + static_assert(is_same<decltype(v15), const _Float16>::value, ""); > + static_assert(v15 == 1.F16, ""); > + > + static constexpr auto v16 = 1.F16; // OK. > + static_assert(is_same<decltype(v16), const _Float16>::value, ""); > + static_assert(v16 == 1.F16, ""); > + > + static constexpr auto v17 = 1.e0F16; // OK. > + static_assert(is_same<decltype(v17), const _Float16>::value, ""); > + static_assert(v17 == 1.F16, ""); > +} > + > +void float16_hexadecimal_literals() { > +// _Float16 > + > + static constexpr auto v13 = 0xfp0f16; > + // CHECK-MESSAGES: :[[@LINE-1]]:31: warning: floating point literal has > suffix 'f16', which is not uppercase > + // CHECK-MESSAGES-NEXT: static constexpr auto v13 = 0xfp0f16; > + // CHECK-MESSAGES-NEXT: ^ ~ > + // CHECK-MESSAGES-NEXT: {{^ *}}F16{{$}} > + // CHECK-FIXES: static constexpr auto v13 = 0xfp0F16; > + static_assert(is_same<decltype(v13), const _Float16>::value, ""); > + static_assert(v13 == 0xfp0F16, ""); > + > + static constexpr auto v14 = 0xfp0F16; // OK. > + static_assert(is_same<decltype(v14), const _Float16>::value, ""); > + static_assert(v14 == 0xfp0F16, ""); > + > +} > > Modified: > clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-floating-point.cpp > URL: > http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-floating-point.cpp?rev=352231&r1=352230&r2=352231&view=diff > ============================================================================== > --- > clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-floating-point.cpp > (original) > +++ > clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-floating-point.cpp > Fri Jan 25 11:05:12 2019 > @@ -3,8 +3,6 @@ > // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' > -fix -- -target x86_64-pc-linux-gnu -I %S > // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' > -warnings-as-errors='-*,readability-uppercase-literal-suffix' -- -target > x86_64-pc-linux-gnu -I %S > > -// REQUIRES: disabled > - > #include "readability-uppercase-literal-suffix.h" > > void floating_point_suffix() { > @@ -99,34 +97,6 @@ void floating_point_suffix() { > static constexpr auto v13 = 1.e0Q; // OK. > static_assert(is_same<decltype(v13), const __float128>::value, ""); > static_assert(v13 == 1., ""); > - > - // _Float16 > - > - static constexpr auto v14 = 1.f16; > - // CHECK-MESSAGES: :[[@LINE-1]]:31: warning: floating point literal has > suffix 'f16', which is not uppercase > - // CHECK-MESSAGES-NEXT: static constexpr auto v14 = 1.f16; > - // CHECK-MESSAGES-NEXT: ^ ~ > - // CHECK-MESSAGES-NEXT: {{^ *}}F16{{$}} > - // CHECK-FIXES: static constexpr auto v14 = 1.F16; > - static_assert(is_same<decltype(v14), const _Float16>::value, ""); > - static_assert(v14 == 1.F16, ""); > - > - static constexpr auto v15 = 1.e0f16; > - // CHECK-MESSAGES: :[[@LINE-1]]:31: warning: floating point literal has > suffix 'f16', which is not uppercase > - // CHECK-MESSAGES-NEXT: static constexpr auto v15 = 1.e0f16; > - // CHECK-MESSAGES-NEXT: ^ ~ > - // CHECK-MESSAGES-NEXT: {{^ *}}F16{{$}} > - // CHECK-FIXES: static constexpr auto v15 = 1.e0F16; > - static_assert(is_same<decltype(v15), const _Float16>::value, ""); > - static_assert(v15 == 1.F16, ""); > - > - static constexpr auto v16 = 1.F16; // OK. > - static_assert(is_same<decltype(v16), const _Float16>::value, ""); > - static_assert(v16 == 1.F16, ""); > - > - static constexpr auto v17 = 1.e0F16; // OK. > - static_assert(is_same<decltype(v17), const _Float16>::value, ""); > - static_assert(v17 == 1.F16, ""); > } > > void floating_point_complex_suffix() { > > Modified: > clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-hexadecimal-floating-point.cpp > URL: > http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-hexadecimal-floating-point.cpp?rev=352231&r1=352230&r2=352231&view=diff > ============================================================================== > --- > clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-hexadecimal-floating-point.cpp > (original) > +++ > clang-tools-extra/trunk/test/clang-tidy/readability-uppercase-literal-suffix-hexadecimal-floating-point.cpp > Fri Jan 25 11:05:12 2019 > @@ -3,8 +3,6 @@ > // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' > -fix -- -target x86_64-pc-linux-gnu -I %S > // RUN: clang-tidy %t.cpp -checks='-*,readability-uppercase-literal-suffix' > -warnings-as-errors='-*,readability-uppercase-literal-suffix' -- -target > x86_64-pc-linux-gnu -I %S > > -// REQUIRES: disabled > - > #include "readability-uppercase-literal-suffix.h" > > void floating_point_suffix() { > @@ -95,21 +93,6 @@ void floating_point_suffix() { > static constexpr auto v12 = 0xfp0Q; // OK. > static_assert(is_same<decltype(v12), const __float128>::value, ""); > static_assert(v12 == 0xfp0, ""); > - > - // _Float16 > - > - static constexpr auto v13 = 0xfp0f16; > - // CHECK-MESSAGES: :[[@LINE-1]]:31: warning: floating point literal has > suffix 'f16', which is not uppercase > - // CHECK-MESSAGES-NEXT: static constexpr auto v13 = 0xfp0f16; > - // CHECK-MESSAGES-NEXT: ^ ~ > - // CHECK-MESSAGES-NEXT: {{^ *}}F16{{$}} > - // CHECK-FIXES: static constexpr auto v13 = 0xfp0F16; > - static_assert(is_same<decltype(v13), const _Float16>::value, ""); > - static_assert(v13 == 0xfp0F16, ""); > - > - static constexpr auto v14 = 0xfp0F16; // OK. > - static_assert(is_same<decltype(v14), const _Float16>::value, ""); > - static_assert(v14 == 0xfp0F16, ""); > } > > void floating_point_complex_suffix() { > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
