riccibruno marked 5 inline comments as done.
riccibruno added inline comments.
================
Comment at: include/clang/AST/Expr.h:5122
+ AssociationIteratorTy() = default;
+ AssociationTy<Const> operator*() const {
+ return AssociationTy<Const>(cast<Expr>(*E), *TSI,
----------------
aaron.ballman wrote:
> riccibruno wrote:
> > aaron.ballman wrote:
> > > Can this continue to return `reference` instead of the concrete type?
> > > (Same in the cast expression.)
> > Not literally `reference` since the base is dependent, but `typename
> > BaseTy::reference` should work. Is that what you mean ?
> Yes, that's what I meant, sorry. :-)
Right. I will land this today when I have some time. Thanks for the review !
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57106/new/
https://reviews.llvm.org/D57106
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
