steveire added a comment.

I was just working on this this afternoon to show you the difference when it is 
split up. Looks like you committed this meanwhile.

While building I noticed that you introduced a `-Wreorder` bug in D57238 
<https://reviews.llvm.org/D57238>, which isn't surprising given how many 
different things you do in that one commit :). It looks like you fixed that bug 
before commit though.

Thanks for the refactor!

Stephen.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57104/new/

https://reviews.llvm.org/D57104



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to