aaron.ballman added inline comments.
================
Comment at: include/clang/AST/Expr.h:5084
+ /// storage of Stmt * and TypeSourceInfo * in GenericSelectionExpr.
+ template <bool Const> class AssociationIteratorTy {
+ friend class GenericSelectionExpr;
----------------
riccibruno wrote:
> dblaikie wrote:
> > Worth using any of the iterator helpers LLVM has? (iterator_facade or the
> > like)
> I did try to use `iteratore_facade` but for some reason I was getting strange
> overload resolution failures with it.
>
> In the end it did not save much and so I just rewrote the boiler-plate
> (especially given that if we end up going with an input iterator there is not
> going to be much boiler-plate).
Does using the `iterator_facade_base` help now that we're back to an input
iterator? It seems like that should be able to get rid of some of the
boilerplate.
================
Comment at: include/clang/AST/Expr.h:5100
+ public:
+ // Note: This iterator could conceptually be a random access iterator.
+ // However this iterator do not satisfy two requirements of forward
----------------
Note -> FIXME
iterator. -> iterator, and it would be nice if we could strengthen the iterator
category someday.
================
Comment at: include/clang/AST/Expr.h:5101
+ // Note: This iterator could conceptually be a random access iterator.
+ // However this iterator do not satisfy two requirements of forward
+ // iterators:
----------------
do not -> does not
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57106/new/
https://reviews.llvm.org/D57106
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
