lebedev.ri marked an inline comment as done. lebedev.ri added a comment. @ABataev Thank you for taking a look!
================ Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ + case OMPC_##Name: return ASTNodeKind(NKI_##Class); +#include "clang/Basic/OpenMPKinds.def" ---------------- ABataev wrote: > Well, I think it would be good to filter out `OMPC_flush` somehow because > there is no such clause actually, it is a pseudo clause for better handling > of the `flush` directive. > Are `OMPC_threadprivate` and `OMPC_uniform` also in the same boat? I don't see those clauses in spec. Perhaps `OMPC_flush` should be made more like those other two? (i.e. handled outside of `OPENMP_CLAUSE` macro) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/ https://reviews.llvm.org/D57112 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
