leonardchan marked 2 inline comments as done. leonardchan added inline comments.
================ Comment at: clang/lib/AST/TypePrinter.cpp:958-964 + // Remove the address_space qualifier so it does not get printed. We + // instead want to print the macro only. + SplitQualType SplitTy = AttrTy->getModifiedType().split(); + Qualifiers Quals = SplitTy.Quals; + if (Quals.getAddressSpace() >= LangAS::FirstTargetAddressSpace) + Quals.removeAddressSpace(); + return printBefore(SplitTy.Ty, Quals, OS); ---------------- leonardchan wrote: > This has not been addressed yet in this patch, but will still make another > patch moving the address_space from the qualifier to the AttributedType (in > reference to r340765). @rsmith Finally fixed in D55447, so I don't think there are any more outstanding prior comments that haven't been addressed in this patch so far. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
