steveire added a comment. Splitting the introduction of and porting to `Create` would significantly reduce the number of files touched by the 'real' change in this commit, and therefore reduce noise in the commit (following the idea of "do one thing per commit" to make the code reviewable in the future).
However, if you're opposed to that, it's not a hard requirement. ================ Comment at: include/clang/AST/Expr.h:5048 + // are the associated expressions. + return 1 + getNumAssocs(); + } ---------------- Would it be correct to use `ASSOC_EXPR_START` here instead of the magic `1`? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57104/new/ https://reviews.llvm.org/D57104 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
