JonasToth added inline comments.
================ Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:133 + StringRef Correct = + HasFinal ? "'" + FinalMacro + "'" : "'" + OverrideMacro + "'"; ---------------- Dangling? These values seem to be temporary and `StringRef` would bind to the temporary, not? For the concatenation `llvm::Twine` would be better as well, same in the other places. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57087/new/ https://reviews.llvm.org/D57087 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
