smeenai added inline comments.

================
Comment at: cfe/trunk/cmake/caches/Fuchsia-stage2.cmake:29
 
-set(LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "")
 set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "")
----------------
Out of curiosity, how come you decided to disable assertions? 
https://reviews.llvm.org/D41471 said "Release+Asserts is fast enough. No need 
to let insanity through.", and I do think assertions end up catching a bunch of 
issues, so I was wondering if the build time penalty became too high.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56652/new/

https://reviews.llvm.org/D56652



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to