riccibruno added a comment.
Some small additional remarks if you are already modifying this class.
================
Comment at: include/clang/AST/Expr.h:5021
unsigned NumAssocs, ResultIndex;
SourceLocation GenericLoc, DefaultLoc, RParenLoc;
----------------
It is possible to stuff one `SourceLocation` in the bit-fields of `Stmt` to
save one more pointer.
================
Comment at: include/clang/AST/Expr.h:5113
SourceLocation getBeginLoc() const LLVM_READONLY { return GenericLoc; }
SourceLocation getEndLoc() const LLVM_READONLY { return RParenLoc; }
----------------
I believe these `LLVM_READONLY` are pointless here.
================
Comment at: include/clang/AST/Expr.h:5125
}
friend class ASTStmtReader;
};
----------------
Move this friend decl to the top ?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56959/new/
https://reviews.llvm.org/D56959
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
