ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clangd/GlobalCompilationDatabase.cpp:24
+void AdjustArguments(tooling::CompileCommand &Cmd,
+ const std::string &ResourceDir) {
+ // Strip plugin related command line arguments. Clangd does
----------------
kadircet wrote:
> ilya-biryukov wrote:
> > kadircet wrote:
> > > ilya-biryukov wrote:
> > > > NIT: use `StringRef`
> > > Need a string for the concatenation below, when pushing to vector.
> > > Otherwise we get a Twine
> > Why not call `.str()` on a Twine?
> Sure it is also an option but didn't think it would look any better, but
> there you go.
Looks kinda ugly, but **so** efficient... (Not that we care much here)
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56841/new/
https://reviews.llvm.org/D56841
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
