On Thu, Jan 17, 2019 at 3:56 PM Reid Kleckner via cfe-commits <cfe-commits@lists.llvm.org> wrote: > > Author: rnk > Date: Thu Jan 17 12:52:46 2019 > New Revision: 351478 > > URL: http://llvm.org/viewvc/llvm-project?rev=351478&view=rev > Log: > Fix -Wsign-compare in new tests
Thank you for the warning fix -- I wasn't seeing the diagnostics with MSVC. ~Aaron > > Modified: > cfe/trunk/unittests/Lex/PPCallbacksTest.cpp > > Modified: cfe/trunk/unittests/Lex/PPCallbacksTest.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Lex/PPCallbacksTest.cpp?rev=351478&r1=351477&r2=351478&view=diff > ============================================================================== > --- cfe/trunk/unittests/Lex/PPCallbacksTest.cpp (original) > +++ cfe/trunk/unittests/Lex/PPCallbacksTest.cpp Thu Jan 17 12:52:46 2019 > @@ -432,25 +432,25 @@ TEST_F(PPCallbacksTest, OpenCLExtensionP > > TEST_F(PPCallbacksTest, DirectiveExprRanges) { > const auto &Results1 = DirectiveExprRange("#if FLUZZY_FLOOF\n#endif\n"); > - EXPECT_EQ(Results1.size(), 1); > + EXPECT_EQ(Results1.size(), 1U); > EXPECT_EQ( > GetSourceStringToEnd(CharSourceRange(Results1[0].ConditionRange, > false)), > "FLUZZY_FLOOF"); > > const auto &Results2 = DirectiveExprRange("#if 1 + 4 < 7\n#endif\n"); > - EXPECT_EQ(Results2.size(), 1); > + EXPECT_EQ(Results2.size(), 1U); > EXPECT_EQ( > GetSourceStringToEnd(CharSourceRange(Results2[0].ConditionRange, > false)), > "1 + 4 < 7"); > > const auto &Results3 = DirectiveExprRange("#if 1 + \\\n 2\n#endif\n"); > - EXPECT_EQ(Results3.size(), 1); > + EXPECT_EQ(Results3.size(), 1U); > EXPECT_EQ( > GetSourceStringToEnd(CharSourceRange(Results3[0].ConditionRange, > false)), > "1 + \\\n 2"); > > const auto &Results4 = DirectiveExprRange("#if 0\n#elif FLOOFY\n#endif\n"); > - EXPECT_EQ(Results4.size(), 2); > + EXPECT_EQ(Results4.size(), 2U); > EXPECT_EQ( > GetSourceStringToEnd(CharSourceRange(Results4[0].ConditionRange, > false)), > "0"); > @@ -459,7 +459,7 @@ TEST_F(PPCallbacksTest, DirectiveExprRan > "FLOOFY"); > > const auto &Results5 = DirectiveExprRange("#if 1\n#elif FLOOFY\n#endif\n"); > - EXPECT_EQ(Results5.size(), 2); > + EXPECT_EQ(Results5.size(), 2U); > EXPECT_EQ( > GetSourceStringToEnd(CharSourceRange(Results5[0].ConditionRange, > false)), > "1"); > @@ -469,14 +469,14 @@ TEST_F(PPCallbacksTest, DirectiveExprRan > > const auto &Results6 = > DirectiveExprRange("#if defined(FLUZZY_FLOOF)\n#endif\n"); > - EXPECT_EQ(Results6.size(), 1); > + EXPECT_EQ(Results6.size(), 1U); > EXPECT_EQ( > GetSourceStringToEnd(CharSourceRange(Results6[0].ConditionRange, > false)), > "defined(FLUZZY_FLOOF)"); > > const auto &Results7 = > DirectiveExprRange("#if 1\n#elif defined(FLOOFY)\n#endif\n"); > - EXPECT_EQ(Results7.size(), 2); > + EXPECT_EQ(Results7.size(), 2U); > EXPECT_EQ( > GetSourceStringToEnd(CharSourceRange(Results7[0].ConditionRange, > false)), > "1"); > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
