lebedev.ri added a comment. In D56786#1359903 <https://reviews.llvm.org/D56786#1359903>, @ymandel wrote:
> In D56786#1359879 <https://reviews.llvm.org/D56786#1359879>, @steveire wrote: > > > Can you break this up into multiple commits? > > > Sure, but any suggestions on granularity? E.g. i can split into two: the > fixes/clarifications in one and the new matcher in another; or i could split > into four -- one for each bullet, etc. Each matcher separately would be best, you then end up with 3x NFC doc-only changes, and 2x matchers. ================ Comment at: include/clang/ASTMatchers/ASTMatchers.h:3346 + +/// Overloaded to match the type's declaration. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, ---------------- How is this different from the other one? Presumably it should have it's own docs. ================ Comment at: include/clang/ASTMatchers/ASTMatchers.h:3350-3353 + using ::clang::ast_matchers::on; + using ::clang::ast_matchers::anyOf; + using ::clang::ast_matchers::hasType; + using ::clang::ast_matchers::pointsTo; ---------------- I don't think these are needed. You don't have them in the matcher above yet it presumably compiles. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56786/new/ https://reviews.llvm.org/D56786 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
