Lekensteyn added a comment.
Changes still look reasonable, but the preceding path
(https://reviews.llvm.org/D56769) needs some work.
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:607
llvm::DIFile *CUFile = DBuilder.createFile(
- remapDIPath(MainFileName), remapDIPath(getCurrentDirname()), CSInfo,
+ MainFileName, remapDIPath(getCurrentDirname()), CSInfo,
getSource(SM, SM.getMainFileID()));
----------------
Any reason for dropping `remapDIPath` here? Wouldn't this result in the full
path being included even when using:
clang -fdebug-prefix-map=/full/path/= /full/path/source.c
================
Comment at: lib/Lex/PPMacroExpansion.cpp:1466
+ for (const auto &Entry : MacroPrefixMap)
+ if(llvm::sys::path::replace_path_prefix(Path, Entry.first, Entry.second))
+ break;
----------------
Style: space between `if` and `(`
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49466/new/
https://reviews.llvm.org/D49466
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
