aaron.ballman added inline comments.

================
Comment at: lib/AST/ASTDumper.cpp:637
+  if (!D->param_begin() && D->getNumParams())
+    OS << " <<NULL params x " << D->getNumParams() << ">>";
+
----------------
aaron.ballman wrote:
> Extra whitespace at the start of the string literal, or is that intentional? 
> Also, do we want to standardize on `<<<NULL>>>` with three brackets instead 
> of two?
Ah, I understand the whitespace now, so that was intentional I believe. 
Question remains about whether we want to also switch to use `<<<` consistently 
remains though.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56753/new/

https://reviews.llvm.org/D56753



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to