ilya-biryukov added a comment. Just a small comment wrt to a particular change in `ClangdLSPServer`. I haven't looked at the patch more closely, though.
================ Comment at: clangd/ClangdLSPServer.h:132 - RealFileSystemProvider FSProvider; /// Options used for code completion ---------------- Could we instead call `getRealFS()` when we try to initialize a clang-tidy options provider in `main()` and avoid changing this? To avoid adding extra non-real-fs "modes of operation" to `ClangdLSPServer`. Unless you see other uses for this. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55256/new/ https://reviews.llvm.org/D55256 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
