[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai marked an inline comment as done.
vsapsai added inline comments.


================
Comment at: clang/lib/Lex/Preprocessor.cpp:573-574
     if (!File) {
       Diag(SourceLocation(), diag::err_pp_through_header_not_found)
           << PPOpts->PCHThroughHeader;
       return;
----------------
I didn't enhance the diagnostics in this place for `-pch-through-header` case 
because it adds extra code and complexity with little benefit. The reason I 
think there'll be little benefit is because `-pch-through-header` is for 
MSVC-style precompiled headers while frameworks are used mostly on Darwin.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56561/new/

https://reviews.llvm.org/D56561



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits