MyDeveloperDay added inline comments.
================ Comment at: test/clang-tidy/modernize-use-trailing-return.cpp:1 +// RUN: %check_clang_tidy %s modernize-use-trailing-return %t -- -- --std=c++14 + ---------------- bernhardmgruber wrote: > MyDeveloperDay wrote: > > nit: is there a reason here why you say C++14 when the code checks for > > C++11? > Yes. The tests contain functions with deduced return types, such as `auto > f();`. Those require C++14. The check itself is fine with C++11. I kind of half guessed it would be something like that after I hit submit, I noticed some checks add secondary test files which test the various versions of C++, to be honest I found this useful for the checker I'm developing, especially as the checker has some slightly different behavior with C++11 to C++17, but maybe yours doesn't to be honest i'm also fairly new here so don't know exactly the convention examples where this is already done in other peoples checkers modernize-deprecated-headers-cxx03.cpp modernize-deprecated-headers-cxx11.cpp ``` // RUN: %check_clang_tidy %s modernize-deprecated-headers %t -- -extra-arg-before=-isystem%S/Inputs/modernize-deprecated-headers -- -std=c++03 -v // RUN: %check_clang_tidy %s modernize-deprecated-headers %t -- -extra-arg-before=-isystem%S/Inputs/modernize-deprecated-headers -- -std=c++11 -v ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
