NoQ marked an inline comment as done.
NoQ added inline comments.
================
Comment at: lib/StaticAnalyzer/Core/Store.cpp:410
+ QualType OrigTy = R->getValueType();
+
----------------
NoQ wrote:
> NoQ wrote:
> > This is entirely incorrect. The whole point of this function is to handle
> > the case when `R->getValueType()` has nothing to do with the original type
> > of `V`.
> >
> > Unfortunately, "type of an `SVal`" is not a thing, so it's going to be a
> > bit more verbose.
> Relevant test case:
> ```
> double no_crash_reinterpret_double_as_int(double a) {
> *(int *)&a = 1;
> return a * a;
> }
> ```
...which crashes after this patch while trying to multiply 1 by 1 and return
result as double.
(sry for the noise)
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55875/new/
https://reviews.llvm.org/D55875
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
