[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: clang/test/CodeGenObjCXX/inheriting-constructor-cleanup.mm:10
+  // Use variadic args to force inlining the inherited constructor.
+  Base(const Strong &s, ...) {}
+};
----------------
To test what I'd like to see, this needs to take `Strong` by value, not by 
reference.  There won't be a cleanup for the inlined parameter if it's taken by 
reference.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55543/new/

https://reviews.llvm.org/D55543



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits