kadircet added inline comments.

================
Comment at: clangd/index/Background.cpp:464
+  if (BuildIndexPeriodMs > 0)
+    SymbolsUpdatedSinceLastIndex = true;
+  else
----------------
why not simply check if `BuildIndexPeriodMs` has passed and issue rebuild here? 
That way we won't spawn an additional thread, and get rid of the CV


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55770/new/

https://reviews.llvm.org/D55770



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to