ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clangd/index/Background.h:121 bool ShouldStop = false; - std::deque<Task> Queue; + std::deque<std::pair<Task, ThreadPriority>> Tasks; std::vector<std::thread> ThreadPool; // FIXME: Abstract this away. ---------------- This rename makes the diff look a bit more complicated than it actually is. I personally like the new name better, but the old name also seemed ok. Maybe considering keeping the old name to make the diff simpler? Up to you, though, this does not seem terribly important. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55315/new/ https://reviews.llvm.org/D55315 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
