erichkeane marked an inline comment as done. erichkeane added inline comments.
================ Comment at: test/CodeGenCXX/mangle-address-space.cpp:7 +// CHECKNOOCL-LABEL: define {{.*}}void @_Z2f0Pc +// WINNOOCL-LABEL: define {{.*}}void @"?f0@@YAXPEAD@Z" +// CHECKOCL-LABEL: define {{.*}}void @_Z2f0PU9CLgenericc ---------------- rnk wrote: > erichkeane wrote: > > rnk wrote: > > > You know, now that we have a demangler, I wonder if we shouldn't add a > > > RUN line like this to test that these names really do demangle properly: > > > `// RUN: %clang_cc1 %s ... -emit-bitcode -o - | llvm-nm -demangle - | > > > FileCheck %s --check-prefix=DEMANGLED` > > I'm not sure how that would work, but I can take a look. > Any thoughts on this? I see, llvm-nm -demangle doesn't call the microsoft > demangler. I wasn't able to find a way that would call this. Also, some of my test machines don't seem to default build llvm-undname always (which would be required for the windows ones). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55715/new/ https://reviews.llvm.org/D55715 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits