rsmith added a comment.

I think you missed this from my previous review:

> This should be checked and diagnosed in Sema, not in CodeGen.



================
Comment at: lib/CodeGen/CGDeclCXX.cpp:333-337
@@ +332,7 @@
+          [](const CXXMethodDecl *Method) { return Method->isVirtual(); }))
+    return false;
+
+  // .. and no virtual base classes.
+  if (RD->getNumVBases() != 0)
+    return false;
+
----------------
You can check these conditions with `RD->isDynamicClass()`.


http://reviews.llvm.org/D15305



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to