aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
A few more minor nits.
================
Comment at: docs/LibASTMatchersReference.html:2579-2581
+ y(x); Matches
+ NS::y(x); Doesn't match
+ y(42); Doesn't match.
----------------
This is not your bug to fix, but it seems the documentation generator is
stripping the comment markers. This impacts other matchers as well, such as
`throughUsingDecl()`.
================
Comment at: include/clang/Sema/Overload.h:831
+ private:
+ // Only the OverloadCandidate set is allowed to construct
OverloadCandidates.
+ friend class OverloadCandidateSet;
----------------
OverloadCandidate set -> OverloadCandidateSet ? (I'd also be fine with
removing the comment -- seems somewhat obvious from context.)
================
Comment at: lib/Sema/SemaExpr.cpp:5672
CallExpr *TheCall;
- if (Config)
+ if (Config) {
TheCall = new (Context)
----------------
No need to add the braces here (alternatively, add them to the `else` clause).
================
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:204
+ StatementMatcher ADLMatch = callExpr(usesADL());
+ auto NS_Str = R"DELIM(
+ namespace NS {
----------------
EricWF wrote:
> fowles wrote:
> > if you use cc or cpp as your delimiter, I think clang-format will recurse
> > correctly
> That's super cool. Thanks!
Wow, that is really neat!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55534/new/
https://reviews.llvm.org/D55534
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
