Szelethus added a comment.
I can't fix these right away, but I don't want myself to forget it before
commiting. Pay no attention.
================
Comment at: include/clang/StaticAnalyzer/Checkers/CheckerBase.td:51-56
+/// relies on information MallocBase gathers.
+/// Example:
+/// def InnerPointerChecker : Checker<"InnerPointer">,
+/// HelpText<"Check for inner pointers of C++ containers used after "
+/// "re/deallocation">,
+/// Dependencies<[MallocBase]>;
----------------
`MallocBase` was renamed to `DynamicMemoryModeling`
================
Comment at: include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:104
StringRef Desc;
+ llvm::SmallVector<const CheckerInfo *, 0> Dependencies;
----------------
Should be `ConstCheckerInfoList`.
================
Comment at: include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:139
+ /// Makes the checker with the full name \p fullName depends on the checker
+ /// called \p dependency.
----------------
typo: depend
================
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:174
+
+ assert(std::is_sorted(Checkers.cbegin(), Checkers.cend(), checkerNameLT));
+
----------------
The same assert in there just a couple lines above.
================
Comment at: utils/TableGen/ClangSACheckersEmitter.cpp:102-103
+ // alpha.cplusplus.UninitializedObject
+ // - CLASS: The name of the checker, with "Checker" appended, e.g.:
+ // UninitializedObjectChecker
+ // - HELPTEXT: The description of the checker.
----------------
This is incorrect.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54438/new/
https://reviews.llvm.org/D54438
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
