MyDeveloperDay added inline comments.
================
Comment at: clang-tidy/modernize/UseNodiscardCheck.cpp:43
+ // function like _Foo()
+ if (ignore){
+ return doesFunctionNameStartWithUnderScore(&Node);
----------------
curdeius wrote:
> If think that you should run clang-format over your patch.
Sorry my bad, I do have clang-format to run on save which should pick up your
style, but I forgot you guys don't like braces on small ifs...
================
Comment at: docs/clang-tidy/checks/modernize-use-nodiscard.rst:62
+Users can use :option:`IgnoreInternalFunctions` to turn off the adding of
+``[nodiscard]]`` to functions starting with _ e.g. _Foo()
+
----------------
curdeius wrote:
> curdeius wrote:
> > Missing leading `[` in `[nodiscard]]`, should be `[[nodiscard]]`
> It might have been discussed already, but is it a common convention to mark
> internal functions with a leading underscore?
> If that comes from system headers, AFAIK clang-tidy already is able not to
> emit warnings from them.
If you feel this is an unnecessary option, I'm happy to remove it, it might
simplify things.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55433/new/
https://reviews.llvm.org/D55433
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
