akyrtzi added inline comments.
================
Comment at: lib/Index/USRGeneration.cpp:274
+ if (unsigned quals = MD->getTypeQualifiers().getCVRUQualifiers())
Out << (char)('0' + quals);
switch (MD->getRefQualifier()) {
----------------
rjmccall wrote:
> akyrtzi wrote:
> > rjmccall wrote:
> > > Paging @akyrtzi here. The address-space qualifier should be part of the
> > > USR but I don't think if there's a defined schema for that.
> > If I understand correctly from other comments you can't add special
> > mangling and USR generation yet and intend to add FIXME for doing mangling
> > support later ? If yes, could you also add FIXME here and re-visit ?
> While you're here, can you described the right way for us to extend USR
> generation here to potentially add an address space?
I'm not familiar with the mechanism, is address space supposed to be identified
via a single integer ? If so, then I think adding '-' character plus the
integer as character for the address space, immediately after the type
qualifiers, should be a way to go.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54862/new/
https://reviews.llvm.org/D54862
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
