Szelethus added a comment. I like what I'm seeing.
In D55226#1320281 <https://reviews.llvm.org/D55226#1320281>, @Pierre-vh wrote: > Hi again! > > As I'm quite new to this, I don't know what the next step is. Do we need to > wait for more people to review this diff? > What happens when it's considered "ready"? How is it committed? (I don't > have commit access) Welcome! :) Always great to see new people around. Once the revision is accepted (and, preferably accepted by someone knowledgeable in the analyzer) you may commit. When you start contributing to the project, and you don't have commit access just yet, you should ask someone who does to commit the patch on your behalf. Once you have "enough" patches under your belt, you may ask for a commit access. Here are some links with more info on patch reviews, commiting, and the like: https://llvm.org/docs/Contributing.html https://llvm.org/docs/DeveloperPolicy.html ("Making and Submitting a Patch" seems outdated, but the following sections are worth a read: "Code Reviews", "Obtaining Commit Access" (and the rest, if you have the time)) https://llvm.org/docs/Phabricator.html Sadly, I won't be around my working PC for a while, so I can't commit on your behalf just yet. If you asked for someone to commit but no one did, it's perfectly fine to ping it once a week. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55226/new/ https://reviews.llvm.org/D55226 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
