mikael marked an inline comment as done and an inline comment as not done.
mikael added a comment.
Thanks for the feedback, I'll work on fixing the issues!
================
Comment at: lib/Sema/SemaOverload.cpp:1146
+ unsigned OldQuals = OldMethod->getTypeQualifiers().getCVRUQualifiers();
+ unsigned NewQuals = NewMethod->getTypeQualifiers().getCVRUQualifiers();
if (!getLangOpts().CPlusPlus14 && NewMethod->isConstexpr() &&
----------------
rjmccall wrote:
> This is an algorithm that I think you need to get right and which shouldn't
> drop address spaces.
But with this patch we can only have __generic address space for methods. So if
I try to implement something here I can't really test it? Or am I missing
something?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54862/new/
https://reviews.llvm.org/D54862
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
