Szelethus added a comment. From what I can see, this patch LGTM, but I lack the experience in the CTU department just yet to give any meaningful feedback.
================ Comment at: lib/CrossTU/CrossTranslationUnit.cpp:147 llvm::Expected<const FunctionDecl *> CrossTranslationUnitContext::getCrossTUDefinition(const FunctionDecl *FD, ---------------- Would it be worth to add a comment that this function never returns with `nullptr` on success? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55280/new/ https://reviews.llvm.org/D55280 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
