xazax.hun accepted this revision.
xazax.hun added inline comments.

================
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:249
 CrossTranslationUnitContext::importDefinition(const FunctionDecl *FD) {
+  assert(FD->hasBody() && "Functions to be imported should have body.");
+
----------------
I wonder if this actually is true. While it is not supported now, we 
could/might use this to import/merge attributes even without definition. 
But of course, I have no hard feelings about having this assert now and remove 
it later on once other use cases are actually supported.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55132/new/

https://reviews.llvm.org/D55132



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to