ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
Thank, LGTM. A few NITs. ================ Comment at: clangd/index/IndexAction.h:31 + std::function<void(RefSlab)> RefsCallback, + std::function<void(IncludeGraph)> IncludeGraphCallback = nullptr); ---------------- We have only two call sites, maybe leave out the default arg and specify null explicitly where needed? ================ Comment at: unittests/clangd/IndexActionTests.cpp:52 + EXPECT_EQ(Node.URI.data(), IndexFile.Sources->find(URI)->getKeyData()); + } +} ---------------- Maybe also check the size of `IndexFile.Sources` is the same as `Paths`? To make sure we didn't miss any Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54999/new/ https://reviews.llvm.org/D54999 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
