aaron.ballman added a comment.

The summary explains what it's doing, but not why it's doing it -- why is this 
change in behavior needed? Does this not break any tests?

Btw, as we work on this refactoring, I think a good approach will be to build 
up the base of tests around AST dumping so that we can be explicitly aware of 
any behavioral changes from the patches. We have some coverage, but it doesn't 
look to be particularly comprehensive. I am happy to contribute some of these 
tests. WDYT?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55083/new/

https://reviews.llvm.org/D55083



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to