aaron.ballman added a comment.

Overall this seems reasonable, but this change is currently a no-op because 
nothing is using this -- what's the plan for using and testing these changes?



================
Comment at: include/clang/AST/CommentVisitor.h:31
 
-  RetTy Visit(PTR(Comment) C) {
+  RetTy Visit(PTR(Comment) C, ParamTys... P) {
     if (!C)
----------------
Should this be `ParamTys&&...` because we're forwarding in the actual call? 
(Similar below)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55069/new/

https://reviews.llvm.org/D55069



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to